Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay views are not getting removed from window #35

Open
rajAppmetry opened this issue Feb 27, 2020 · 1 comment
Open

Overlay views are not getting removed from window #35

rajAppmetry opened this issue Feb 27, 2020 · 1 comment

Comments

@rajAppmetry
Copy link

For each and every ReactionButton there will be an "overlay" view and that overlay view is attached to UIApplication window whenever user started to react.

But there is no where you are removing the "overlay" view from window, so because of this if user reacting on 100 cells will lead to create 100 overlay views and it wont get removed from superview even after user came out from that controller.

Steps To Reproduce:

1)Run the example Project
2)Press "View inside Tableview cells"
3)Do reactions in cells
4)Come out from the screen
5)Run the view inspector from your xcode,

You will get similar to this,

Screenshot 2020-02-27 at 4 59 58 PM

I reacted four times, so four overlays + reaction selector got created.

Solution:
We can remove the "overlay" view whenever ReactionButton removed from it's superview

@rajAppmetry
Copy link
Author

rajAppmetry commented Mar 5, 2020

Hi @yannickl did you get time to go through this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant