Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needsUpdate in player's paused state #82

Open
kuehn-sba opened this issue Apr 6, 2017 · 5 comments
Open

needsUpdate in player's paused state #82

kuehn-sba opened this issue Apr 6, 2017 · 5 comments

Comments

@kuehn-sba
Copy link

kuehn-sba commented Apr 6, 2017

Videojs normal behaviour is an update in pause state. So can you please remove the paused condition in animate function (seen in L591 in videojs-panorama.v5)?:

if (!this.player().paused()) {

thx..

@kuehn-sba kuehn-sba changed the title I would like needsUpdate in player's paused state needsUpdate in player's paused state Apr 6, 2017
@yanwsh
Copy link
Owner

yanwsh commented Apr 12, 2017

This issue should be fixed.

@kuehn-sba
Copy link
Author

kuehn-sba commented Apr 24, 2017

no it isn't. There is still "if (!this.player().paused())", which will not update frames in pause mode (for seeking, scrubbing a.s.o.)

@yanwsh
Copy link
Owner

yanwsh commented Apr 25, 2017

Why do you want to update when video paused?

Rendering 3d video is super expensive, it exhaust lots of CPU and memory, so my idea is to avoid rendering if video paused.

But i add additional code to check if user seek the videojs progressbar, so if user scroll the progress bar, it will also updated.

So let me know in which condition its not working.

Thanks.

@yanwsh
Copy link
Owner

yanwsh commented Apr 25, 2017

Wait, i double check, it's not working now. It's a bug. Thank you.

@yanwsh
Copy link
Owner

yanwsh commented Jul 9, 2017

This is supported on v1.0.0, please check here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants