Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot sign if component in a ScrollView #11

Closed
jqtruong opened this issue Jun 7, 2019 · 9 comments
Closed

Cannot sign if component in a ScrollView #11

jqtruong opened this issue Jun 7, 2019 · 9 comments

Comments

@jqtruong
Copy link
Contributor

jqtruong commented Jun 7, 2019

When the Signature component is within a ScrollView, trying to sign will cause the view to scroll instead.

@YanYuanFE
Copy link
Owner

YanYuanFE commented Jun 10, 2019

You can't use Signature in ScrollView yet. You can try adding a signature button in ScrollView, and clicking the button will pop up Modal and display Signature.

@jqtruong
Copy link
Contributor Author

indeed, i did just what you said and it works fine. I thought maybe using PanResponder would help with locking the scroll, but could not make it work. Will close for now, thanks.

@ruegreen
Copy link

Has anyone been able to get this to work in scroll view?? Adding a Modal is not desirable...

@robbywh
Copy link

robbywh commented Jun 15, 2020

@ruegreen i think you can use scrollEnabled props in the ScrollView, when onBegin triggered you can set scrollEnabled with false, when onEnd triggered you can set scrollEnabled with true

@isocra
Copy link

isocra commented Jul 1, 2020

I can confirm that @robbywh's solution works for me. Thanks!!

@robbywh
Copy link

robbywh commented Jul 3, 2020

your welcome @isocra

@davwheat
Copy link

This doesn't seem to work very well any more.

When using @robbywh's method, it scrolls once before allowing me to sign like normal.

Anyone else had this issue/managed to fix it?

See this video for more info: https://u.davwheat.dev/ozBM2i.mp4

@YanYuanFE
Copy link
Owner

@davwheat ,Hi, I think this is not a bug. It is a conflict of interaction design. The touch of ScrollView conflicts with the touch interaction of the signature area. You can try to put the signature component in Modal and add a click button in the ScrollView. When the button is clicked, the display modal, and then sign in the modal.

@Akshaybagai52
Copy link

Thanks @YanYuanFE for your reply
it worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants