Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the best BLEU model #9

Open
lvapeab opened this issue May 19, 2016 · 2 comments
Open

Saving the best BLEU model #9

lvapeab opened this issue May 19, 2016 · 2 comments

Comments

@lvapeab
Copy link

lvapeab commented May 19, 2016

When the best model according to bleu is saved (lines 1218-1223), the stored parameters are those that achieved the best error (best_p), not the best BLEU (i.e. the current ones). I think that best_p = unzip(tparams) is missing at line 1220

@CrossLee1
Copy link

agree with you

@dongyp13
Copy link

I think 'current_params' should be saved, not the 'best_p'. Because 'best_p' is only about error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants