Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI-128]add ldap authenticate support #131

Merged
merged 5 commits into from
Dec 12, 2018
Merged

[KYUUBI-128]add ldap authenticate support #131

merged 5 commits into from
Dec 12, 2018

Conversation

yaooqinn
Copy link
Member

No description provided.

@yaooqinn yaooqinn self-assigned this Dec 11, 2018
@yaooqinn yaooqinn added this to To do in kyuubi via automation Dec 11, 2018
@yaooqinn yaooqinn added this to the v0.4.0 milestone Dec 11, 2018
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #131 into master will increase coverage by 0.29%.
The diff coverage is 90.32%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #131      +/-   ##
===========================================
+ Coverage     73.01%   73.3%   +0.29%     
- Complexity      545     551       +6     
===========================================
  Files            76      77       +1     
  Lines          3335    3413      +78     
  Branches        485     509      +24     
===========================================
+ Hits           2435    2502      +67     
- Misses          638     643       +5     
- Partials        262     268       +6
Impacted Files Coverage Δ Complexity Δ
.../main/scala/yaooqinn/kyuubi/auth/AuthMethods.scala 100% <100%> (+12.5%) 0 <0> (ø) ⬇️
...n/scala/yaooqinn/kyuubi/auth/PlainSaslServer.scala 88.67% <100%> (ø) 16 <0> (ø) ⬇️
...scala/yaooqinn/kyuubi/server/FrontendService.scala 63.79% <100%> (ø) 46 <1> (ø) ⬇️
...r/src/main/scala/org/apache/spark/KyuubiConf.scala 100% <100%> (ø) 0 <0> (ø) ⬇️
...src/main/scala/yaooqinn/kyuubi/auth/AuthType.scala 100% <100%> (+20%) 0 <0> (-3) ⬇️
...scala/yaooqinn/kyuubi/auth/KyuubiAuthFactory.scala 70.45% <50%> (-1.14%) 17 <0> (+1)
...nn/kyuubi/auth/AuthenticationProviderFactory.scala 60% <50%> (-40%) 0 <0> (ø)
...n/scala/yaooqinn/kyuubi/auth/PlainSaslHelper.scala 46.66% <75%> (ø) 0 <0> (ø) ⬇️
...n/kyuubi/auth/LdapAuthenticationProviderImpl.scala 88.46% <88.46%> (ø) 6 <6> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1abd4...942762b. Read the comment docs.

@yaooqinn
Copy link
Member Author

Hi @dockerzhang, would you please help me test this pull request in your ldap environment? thanks.

@dockerzhang
Copy link

@yaooqinn This pr solved my problem, it works fine in my ldap environment. Thanks again.

@dockerzhang
Copy link

@yaooqinn Could you merge all changes to master?

@yaooqinn
Copy link
Member Author

thanks @dockerzhang, pending on travis

@yaooqinn yaooqinn merged commit e960540 into master Dec 12, 2018
kyuubi automation moved this from To do to Done Dec 12, 2018
@yaooqinn yaooqinn deleted the KYUUBI-128 branch December 12, 2018 02:42
@yaooqinn yaooqinn modified the milestone: v0.4.0 Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
kyuubi
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants