Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-cli-htmlbars to remove deprecation warning #76

Open
jacobq opened this issue Jan 29, 2018 · 3 comments
Open

Upgrade ember-cli-htmlbars to remove deprecation warning #76

jacobq opened this issue Jan 29, 2018 · 3 comments

Comments

@jacobq
Copy link

jacobq commented Jan 29, 2018

The current release (1.2.1) triggers an annoying deprecation warning w/ recent versions of Ember that would be fixed by upgrading to the latest release of ember-cli-htmlbars (2.x). Please consider upgrading this.

├─┬ ember-radio-button@1.2.1
│ └─┬ ember-cli-htmlbars@1.3.4
│   └── ember-cli-version-checker@1.3.1 

The deprecation warning looks like this and is described here:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/path/to/project/node_modules/ember-getowner-polyfill/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)
@raycohen
Copy link
Contributor

where does the deprecation warning show up? can you give me a little more info on how exactly to reproduce this?

@jacobq
Copy link
Author

jacobq commented Feb 12, 2018

Good question & thanks for checking this out. The warning shows up on the console during build time (e.g. ember s). I will take a shot at posting reproduction steps later today. I thought it would show up just from installing and running on an empty project but a quick test showed otherwise.

(Update: 2/13 Sorry, still haven't had a chance to do this but have not forgotten about it.)

@tamzinblake
Copy link

I am also encountering this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants