feat(__): added tagged template literal support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zkat this is cool 😄 we've already dropped |
bcoe
reviewed
May 15, 2017
test/y18n-test.js
Outdated
| try { | ||
| // We need to do this wrapper in case y18n gets used in runtimes | ||
| // without template literal support. | ||
| eval('__`Hello ${"Ben"} ${"Coe"}`').should.equal('Hello Ben Coe') // eslint-disable-line |
There was a problem hiding this comment.
might be good to test a translating to another language, so we confirm that the %s replacement works appropriately.
|
Change made! And I updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice little convenience wrapper for those of us with template literals available! It will load just fine on non-es2015 runtimes, too -- you just won't be able to use it.
I couldn't figure out how to do something like this that's good enough for
__n, so I just... didn't. I'd happily write one up if there were an obvious way to do so, though.