fix: nargs was consuming too many arguments

yargs · Jan 20, 2018 · 4fef206 · 4fef206
1 parent 9734d9c
commit 4fef206
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -315,7 +315,7 @@ function parse (args, opts) {
 
     if (available < toEat) error = Error(__('Not enough arguments following: %s', key))
 
-    for (ii = i + 1; ii < (available + i + 1); ii++) {
+    for (ii = i + 1; ii < (Math.min(available, toEat) + i + 1); ii++) {
       setArg(key, args[ii])
     }
 

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -1653,6 +1653,16 @@ describe('yargs-parser', function () {
 
       result.error.message.should.equal('Not enough arguments following: foo')
     })
+
+    it('should not consume more than configured nargs', function () {
+      var result = parser(['--foo', 'a', 'b'], {
+        narg: {
+          foo: 1
+        }
+      })
+
+      result.foo.should.eql('a')
+    })
   })
 
   describe('env vars', function () {