fix: make requiresArg work in conjunction with arrays (#136)

yargs · Oct 6, 2018 · 77ae1d4 · 77ae1d4
1 parent 7df1bd4
commit 77ae1d4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -167,12 +167,12 @@ function parse (args, opts) {
     )) {
       key = arg.match(/^--?(.+)/)[1]
 
-      // nargs format = '--foo a b c'
-      if (checkAllAliases(key, flags.nargs)) {
-        i = eatNargs(i, key, args)
       // array format = '--foo a b c'
-      } else if (checkAllAliases(key, flags.arrays) && args.length > i + 1) {
+      if (checkAllAliases(key, flags.arrays) && args.length > i + 1) {
         i = eatArray(i, key, args)
+      // nargs format = '--foo a b c'
+      } else if (checkAllAliases(key, flags.nargs)) {
+        i = eatNargs(i, key, args)
       } else {
         next = args[i + 1]
 

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -1702,6 +1702,17 @@ describe('yargs-parser', function () {
 
       result.foo.should.eql('a')
     })
+
+    it('should be ignored if input is an array', function () {
+      var result = parser(['--foo', 'a', 'b'], {
+        array: 'foo',
+        narg: {
+          foo: 1
+        }
+      })
+
+      result.foo.should.eql(['a', 'b'])
+    })
   })
 
   describe('env vars', function () {