revert: make requiresArg work in conjunction with arrays (#136)

yargs · Nov 19, 2018 · f4a3063 · f4a3063
1 parent 1eb726b
commit f4a3063
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/index.js b/index.js
@@ -180,12 +180,12 @@ function parse (args, opts) {
     )) {
       key = arg.match(/^--?(.+)/)[1]
 
-      // array format = '--foo a b c'
-      if (checkAllAliases(key, flags.arrays) && args.length > i + 1) {
-        i = eatArray(i, key, args)
       // nargs format = '--foo a b c'
-      } else if (checkAllAliases(key, flags.nargs)) {
+      if (checkAllAliases(key, flags.nargs)) {
         i = eatNargs(i, key, args)
+      // array format = '--foo a b c'
+      } else if (checkAllAliases(key, flags.arrays) && args.length > i + 1) {
+        i = eatArray(i, key, args)
       } else {
         next = args[i + 1]
 

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -1774,17 +1774,6 @@ describe('yargs-parser', function () {
 
       result.foo.should.eql('a')
     })
-
-    it('should be ignored if input is an array', function () {
-      var result = parser(['--foo', 'a', 'b'], {
-        array: 'foo',
-        narg: {
-          foo: 1
-        }
-      })
-
-      result.foo.should.eql(['a', 'b'])
-    })
   })
 
   describe('env vars', function () {