Fix: ensure consistent parsing of dot-notation arguments #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elsbree this looks solid 👍 will work on getting it landed soon. thanks for the contribution. |
|
@elsbree sorry I dropped this on the ground for so long; could I bother you to rebase? |
BREAKING CHANGE: strings that fail `Number.isSafeInteger()` are no longer coerced into numbers.
|
I think I made a bit of a mess with that rebase- sorry about that. |
|
@elsbree I apologize for taking a long time to land things lately, have been pretty slammed with work. appreciate the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101