feat: reworking how numbers are parsed #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
changed the title
ezzatron
reviewed
Oct 4, 2017
index.js
Outdated
| @@ -421,6 +423,14 @@ function parse (args, opts) { | |||
| return value | |||
| } | |||
|
|
|||
| function maybeCoerceNumber (key, value) { | |||
| if (!checkAllAliases(key, flags.strings) && !checkAllAliases(key, flags.coercions)) { | |||
| const shouldCoerceNumber = isNumber(value) && configuration['parse-numbers'] && (Number(value) <= Number.MAX_SAFE_INTEGER) | |||
There was a problem hiding this comment.
It might be better to use Number.isSafeInteger() instead of manually comparing to Number.MAX_SAFE_INTEGER. If you don't, you probably need to think about large negative numbers and using Number.MIN_SAFE_INTEGER too.
elsbree
pushed a commit
to elsbree/yargs-parser
that referenced
this pull request
Dec 1, 2017
BREAKING CHANGE: strings that fail `Number.isSafeInteger()` are no longer coerced into numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins to address issues discussed in yargs/yargs#96, moving us towards
Number.MAX_SAFE_INTEGER.maybeCoerceNumber.parse-numbers = falselogic.