Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: narg arguments no longer consume flag arguments #114

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jan 20, 2018

BREAKING CHANGE: arguments of form --foo, -abc, will no longer be consumed by nargs

This is in prep for replacing the crufty legacy method requiresArg with nargs(1).

CC: @evocateur for review

BREAKING CHANGE: arguments of form --foo, -abc, will no longer be consumed by nargs
Copy link
Contributor

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know nargs could consume flags (before this), this change is much closer to my expectations (but again, I have no familiarity with the Python that inspired nargs).

@bcoe
Copy link
Member Author

bcoe commented Jan 20, 2018

@evocateur I don't remember if I consciously made this design decision when building nargs, or if it was an oversight -- this behavior feels better to me.

@bcoe bcoe merged commit 60bb9b3 into master Jan 20, 2018
@bcoe bcoe deleted the narg-and-flags branch January 20, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants