Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return deno env object #432

Merged
merged 4 commits into from
Feb 27, 2022
Merged

fix: return deno env object #432

merged 4 commits into from
Feb 27, 2022

Conversation

johanholmerin
Copy link
Contributor

@johanholmerin johanholmerin commented Jan 25, 2022

Assume the environment object should actually be returned

Fixes yargs/yargs#2136

@bcoe
Copy link
Member

bcoe commented Feb 26, 2022

@johanholmerin at a glance patch looks good, but seems to not be working as expected in Deno tests.

@johanholmerin
Copy link
Contributor Author

@bcoe Should be fixed now

@bcoe bcoe merged commit b00eb87 into yargs:main Feb 27, 2022
@bcoe
Copy link
Member

bcoe commented Feb 27, 2022

@johanholmerin thank you for the contribution, this should address yargs/yargs#2136 I believe.

@webbertakken
Copy link

Created a PR ^ that will update yargs-parser in yargs, so that .env() can effectively be used again in Deno.

bcoe added a commit to yargs/yargs that referenced this pull request Nov 3, 2022
Currently the `yargs` is not usable in Deno with `.env()`. 
This was fixed in yargs/yargs-parser#432
It was released in yargs-parser v21.0.1
This dependency bump will fix `yargs` for Deno.

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno: yargs.env() fails
4 participants