Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of prefix for boolean negation #94

Merged
merged 3 commits into from
Aug 10, 2017
Merged

Allow configuration of prefix for boolean negation #94

merged 3 commits into from
Aug 10, 2017

Conversation

yitzchak
Copy link
Contributor

@yitzchak yitzchak commented Aug 2, 2017

This PR adds a configuration setting negation-prefix which allows the prefix used in boolean negation to be specified. The default value of no- ensures backward compatibility.

Justification: I am using yargs-parser to parse the command lines of 3rd party programs and not all of them follow the --no-foo convention. Some programs seem to use --nofoo instead of --no-foo.

@bcoe
Copy link
Member

bcoe commented Aug 10, 2017

@yitzchak this seems quite reasonable to me 👍

I am going to go ahead and land, but it might be a few days before I get this pulled into yargs proper. Feel free to join yargs' community chat, if you want to help kick the process along (or would like to learn more about what the release process looks like).

http://devtoolscommunity.herokuapp.com/

@bcoe bcoe merged commit 00bde7d into yargs:master Aug 10, 2017
@yitzchak yitzchak deleted the add-negation-prefix branch August 10, 2017 10:03
@yitzchak
Copy link
Contributor Author

Awesome. Thanks @bcoe

@bcoe
Copy link
Member

bcoe commented Oct 5, 2017

@yitzchak this is now released in yargs-parser@8.0.0; mind trying it out and making sure it works for you?

@yitzchak
Copy link
Contributor Author

yitzchak commented Oct 5, 2017

@bcoe Looks good. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants