Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"extends" should also trigger for files without extension that end in "rc" #1035

Closed
bcoe opened this issue Jan 2, 2018 · 10 comments · Fixed by #1080
Closed

"extends" should also trigger for files without extension that end in "rc" #1035

bcoe opened this issue Jan 2, 2018 · 10 comments · Fixed by #1080

Comments

@bcoe
Copy link
Member

bcoe commented Jan 2, 2018

It's a common convention for a configuration file to end with the suffix rc., e.g., .nycrc; it seems like a good extension to the extends functionality would be to also support filenames of the form .*rc.

Currently extends only supports the .json extension. fixes istanbuljs/nyc#732

CC: @genepaul

@arunasank
Copy link
Contributor

I'm interested in working on this✋

@arunasank
Copy link
Contributor

I was taking a look at some files that have the extension rc, and the contents seem different in different files. For example:

.npmrc

package-lock=false

.babelrc

{
  "presets": ["env"]
}

And the nycrc file seems to be a json file. So, do we intend to only support files with a json format?

@bcoe
Copy link
Member Author

bcoe commented Jan 15, 2018

@arunasank 👋 I've been dealing with some family health issues, so have been working on open-source sporadically; I would love to have your help on this issue. Please don't hesitate to ask me questions in Slack...

And the nycrc file seems to be a json file. So, do we intend to only support files with a json format?

I'm on the fence; if we could support INI format with minimal work, it could be interesting (but I think we should open a separate ticket for discussion.

@genepaul
Copy link
Contributor

@arunasank, have you had a chance to work on this? Otherwise, I can take a crack at it now that I actually have time to get back to this.

@arunasank
Copy link
Contributor

👋 @genepaul I'd still like to work on this if you can help me.

@arunasank
Copy link
Contributor

Oh, saw that you PR-ed already. 👍 Thanks for the fix!

@genepaul
Copy link
Contributor

@arunasank, sorry to pull it out from under you, but when I made the change it was a lot easier than I expected it to be, so I just submitted the PR.

@arunasank
Copy link
Contributor

Don't worry about it - maybe we can work together on another issue. : ) Thanks again for the fix!

@bcoe bcoe closed this as completed in #1080 Mar 4, 2018
@bcoe
Copy link
Member Author

bcoe commented Mar 4, 2018

@arunasank @genepaul good news, I intend to start having a monthly meetup (both in person, and online, for triaging issues on yargs, Istanbul, conventional-commits, etc., and distributing work to the community). I'll try to pick a time that works well across timezones -- unfortunately it might be a bit early in the morning in Bangalore ...

@arunasank
Copy link
Contributor

arunasank commented Mar 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants