New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"extends" should also trigger for files without extension that end in "rc" #1035
Comments
I'm interested in working on this✋ |
I was taking a look at some files that have the extension .npmrc
.babelrc
And the nycrc file seems to be a json file. So, do we intend to only support files with a json format? |
@arunasank 👋 I've been dealing with some family health issues, so have been working on open-source sporadically; I would love to have your help on this issue. Please don't hesitate to ask me questions in Slack...
I'm on the fence; if we could support INI format with minimal work, it could be interesting (but I think we should open a separate ticket for discussion. |
@arunasank, have you had a chance to work on this? Otherwise, I can take a crack at it now that I actually have time to get back to this. |
👋 @genepaul I'd still like to work on this if you can help me. |
Oh, saw that you PR-ed already. 👍 Thanks for the fix! |
@arunasank, sorry to pull it out from under you, but when I made the change it was a lot easier than I expected it to be, so I just submitted the PR. |
Don't worry about it - maybe we can work together on another issue. : ) Thanks again for the fix! |
@arunasank @genepaul good news, I intend to start having a monthly meetup (both in person, and online, for triaging issues on yargs, Istanbul, conventional-commits, etc., and distributing work to the community). I'll try to pick a time that works well across timezones -- unfortunately it might be a bit early in the morning in Bangalore ... |
@bcoe yes! I can do anytime between 6 and 8 am except on Wednesdays when
I've an office call at 7.30. I'm a morning person. : )
|
It's a common convention for a configuration file to end with the suffix
rc
., e.g.,.nycrc
; it seems like a good extension to theextends
functionality would be to also support filenames of the form.*rc
.Currently
extends
only supports the.json
extension. fixes istanbuljs/nyc#732CC: @genepaul
The text was updated successfully, but these errors were encountered: