New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ts): ship yargs.d.ts #1671
Conversation
@mleguen I think in the spirit of SemVer, I would call this step breaking:
Should we just call this our first commit to I think we should perhaps let but, after that short baking period, let's march towards the 16.x release. |
Sorry, I did not progress much on this the past couple of weeks. I only had time to read the incoming notifications from github... I will try to do better in the coming weeks :-) |
@mleguen how do you feel about me getting yargs@15.4.0 released, as I think our continued TypeScript work will be breaking ... perhaps we could try to land the |
I think it is a good idea, not to block the "normal life of yargs" while we
are terminating the switch to ts.
Landing the `.mjs` import too would be great, if a PR is ready.
Le lun. 22 juin 2020 à 18:16, Benjamin E. Coe <notifications@github.com> a
écrit :
… @mleguen <https://github.com/mleguen> how do you feel about me getting
***@***.*** released, as I think our continued TypeScript work will be
breaking ... perhaps we could try to land the .mjs import too, based on
your experiments, and then plan that we'll probably be taking breaking
changes to get this work over the finish line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1671 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGO2ZKOCJHZZFT2AUGBCK3RX57XDANCNFSM4NSWMAHQ>
.
|
@mleguen I did some testing, Node 14 actually seems pretty smart about hits handling of common JS. With yargs, as it is published today, this just works (I believe): import yargs from 'yargs'
console.info(yargs.argv) Without us needing to add any conditional exports. So, I don't think a ton of value in us adding the conditional exports in our case. |
1st part of 5th step of #1586: this PR ships a yargs.d.ts adapted from the one in
@types/yargs
.