[v17] Error with async builder

[danthegoodman]

Problem

Using an async builder used to work but is now producing erroneous results.

Example

Given this minimal script:

const yargs = require('yargs/yargs');
yargs(process.argv.slice(2))
    .strict()
    .command({
      command: 'alpha',
      describe: 'A',
      builder: async (yargs) =>
        yargs
          .command({
            command: 'beta',
            describe: 'B',
            handler: ()=> console.log("It works!"),
          })
          .demandCommand(1),
      handler: ()=>null,
    })
    .demandCommand(1)
    .parse()

The following commands produce this output:

$ npm install yargs@next
$ node script.js alpha beta
script.js alpha

A

Commands:
  script.js alpha alpha  A

Options:
  --help     Show help                                                 [boolean]
  --version  Show version number                                       [boolean]

Unknown argument: beta
$ node script.js alpha alpha beta
It works!

$ npm install yargs@17.0.0-candidate.7
$ node script.js alpha beta
script.js alpha

A

Commands:
  script.js alpha alpha  A

Options:
  --help     Show help                                                 [boolean]
  --version  Show version number                                       [boolean]

Unknown argument: beta

$ npm install yargs@17.0.0-candidate.6
$ node script.js alpha beta
It works!

[bcoe]

@danthegoodman good catch, turned out to be a fairly major bug.

Could you try yargs@17.0.0-candidate.13 and let me know if it works for your use cases?

[danthegoodman]

@bcoe It works! Thank you :)