Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling yargs.reset() loses information about commands #654

Closed
bcoe opened this issue Oct 11, 2016 · 1 comment
Closed

calling yargs.reset() loses information about commands #654

bcoe opened this issue Oct 11, 2016 · 1 comment

Comments

@bcoe
Copy link
Member

bcoe commented Oct 11, 2016

Rather than patching this but, I wonder if we should deprecate reset() as a public method for yargs. I would rather start pointing people towards the non-singleton api: require('yargs/yargs).

CC: @nexdrew, @maxrimue

@bcoe bcoe added the bug label Oct 11, 2016
@bcoe bcoe added the inactive label Nov 10, 2019
@bcoe
Copy link
Member Author

bcoe commented Nov 10, 2019

I believe we've addressed most of the bugs related to reset , and I'm not feeling like there's a pressing reason to retire reset() right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant