Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ureact_amalgamated.hpp #127

Closed
YarikTH opened this issue Aug 18, 2023 · 1 comment
Closed

Get rid of ureact_amalgamated.hpp #127

YarikTH opened this issue Aug 18, 2023 · 1 comment

Comments

@YarikTH
Copy link
Owner

YarikTH commented Aug 18, 2023

Description

ureact/single_include/ureact/ureact_amalgamated.hpp is currently used only for usage in godbolt. It is not installed as part of the library package, it is not provided as part of CMake target, it just exists. And multiplies each library change in two (at least at release time).

So, now, when ureact is added on godbolt, its time to get rid of it and its usage. To do so, need to remove the file, make sure make amalgamate is not in the documentation somewhere and check and fix existing godbolt links which use ureact_amalgamated.hpp.

There is no need in getting rid of make amalgamate itself. godbolt clones main and dev branches nightly, so if something needs testing now, it can be used to create ureact_amalgamated.hpp in the temporary branch.

@YarikTH
Copy link
Owner Author

YarikTH commented Aug 18, 2023

Done

@YarikTH YarikTH closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant