Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support monorepo in monorepo #356

Closed
MrCheater opened this issue Aug 13, 2019 · 2 comments · Fixed by #1819
Closed

[Feature] Support monorepo in monorepo #356

MrCheater opened this issue Aug 13, 2019 · 2 comments · Fixed by #1819
Labels
enhancement New feature or request

Comments

@MrCheater
Copy link

Now yarn does not support different nohoist at different levels of monoreps. This is critical when working with react-native.

  • my-project <- monorepo
    • packages
      • package-a
      • package-b
    • examples
      • my-example <- monorepo in monorepo
        • react-native
        • web

I hope this will change in the future

@MrCheater MrCheater added the enhancement New feature or request label Aug 13, 2019
@arcanis
Copy link
Member

arcanis commented Aug 13, 2019

Because we're not using node_modules anymore (and thus don't have any hoisting), Yarn 2 will not support nohoist, which was always a workaround to a more serious problem.

The real solution here would be for RN to have a native compatibility with PnP, which I expect will have to come from the community (I'll be happy to provide context when needed, but I have very little experience on the RN architecture itself).

Refs: facebook/react-native#22163
Refs: react-native-community/cli#27

cc @empyrical, I remember you started evaluating it last year. Do you think it would be worthwhile to make a new case study to figure out what would be needed for RN to work with PnP?

In the meantime I'll be closing this issue for now as we don't have action items related to nohoist.

@arcanis arcanis closed this as completed Aug 13, 2019
@MrCheater
Copy link
Author

Now react-native (metro bundler) has big problems finding node_modules outside the root of the react-native application and therefore requires manual configuration. Will react-native (metro bundler) really get PnP support in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants