Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Has the nested workspaces/worktree stuff been implemented yet? #447

Closed
telamonian opened this issue Sep 9, 2019 · 1 comment

Comments

@telamonian
Copy link

telamonian commented Sep 9, 2019

Has the nested workspaces/worktree stuff (mentioned here) been implemented yet?

If it has been, I'd like to try it out. I made some hacks to enable one level of yarn workspace nesting in this PR for the Jupyterlab build system, but it looks like my hack doesn't cover every use case (see the test failures). If there's a better form of workspace nesting in v2, I'd like to test it and see if it solves my particular problem.

If it hasn't been implemented yet, can someone please point me towards the relevant source files? I'll see if I can make a PR for it.

@arcanis
Copy link
Member

arcanis commented Sep 11, 2019

Hey @telamonian - Yep, it's been implemented! The one potentially experimental part is that I'm still not sure whether relative workspace ranges (workspace:packages/my-package) should be relative to the project root (as is currently the case) or to the nearest worktree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants