Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: explain peer-requirements [hash] throws error #5977

Closed
1 task
scheinercc opened this issue Nov 15, 2023 · 1 comment · Fixed by #6205
Closed
1 task

[Bug?]: explain peer-requirements [hash] throws error #5977

scheinercc opened this issue Nov 15, 2023 · 1 comment · Fixed by #6205
Labels
bug Something isn't working

Comments

@scheinercc
Copy link

Self-service

  • I'd be willing to implement a fix

Describe the bug

running

yarn explain peer-requirements p2677a

first threw an error,

Unknown Syntax Error: Command not found; did you mean one of:

  0. yarn explain [--json] [code]
  1. yarn explain [--json] [code]

While running explain peer-requirement p6de1a

after yarn down and up grade it now throws

The yarn explain peer-requirements command doesn't support this warning type yet.

To reproduce

minimum package file

{
  "devDependencies": {
    "@angular-eslint/template-parser": "^15.2.1"
  },
  "packageManager": "yarn@4.0.2"
}
  1. Just updated to 4.0.2

  2. run yarn
    I got

    ➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide eslint (p6936f), requested by @angular-eslint/template-parser.
    ➤ YN0002: │ root-workspace-0b6124@workspace:. doesn't provide typescript (p7ea97), requested by @angular-eslint/template-parser.
    ➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
    
  3. run

     yarn explain peer-requirements p6de1a
    

    I got

    Unknown Syntax Error: Command not found; did you mean one of:
    
      0. yarn explain [--json] [code]
      1. yarn explain [--json] [code]
    
    While running explain peer-requirement p6de1a
    
  4. Test no.1 downgraded to 4.0.1 -

    • yarn set version 4.0.1,
    • ran yarn etc. same result.
  5. Test no.2 downgraded to 3.x, at first I got the same error running yarn explain ...,

  6. after running it without hash

    yarn explain peer-requirement
    

    I got the list of peer-requirements with hashes, then yarn explain peer-requirements p6de1a worked.

  7. Upgraded to 4.0.2, ran yarn etc. the message changed to

    $ yarn explain peer-requirements p6de1a
    
    The yarn explain peer-requirements command doesn't support this warning type yet.
    

Environment

System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 20.8.0 - /private/var/folders/sm/mwb025n96m1g11lncvl4h2_r0000gn/T/xfs-d7d42f00/node
    Yarn: 4.0.2 - /private/var/folders/sm/mwb025n96m1g11lncvl4h2_r0000gn/T/xfs-d7d42f00/yarn
    npm: 10.1.0 - /opt/homebrew/bin/npm

Additional context

No response

@scheinercc scheinercc added the bug Something isn't working label Nov 15, 2023
@scheinercc scheinercc changed the title [Bug?]: explain peer-requirements [hash] thows error [Bug?]: explain peer-requirements [hash] throws error Nov 15, 2023
@lindenwells
Copy link

The maintainer said in this PR: #5834

Note that I temporarily removed support for calling yarn explain peer-requirements on missing peer dependencies, as I'd like to take another look at those warnings in general (I noticed they aren't aggregated, but they probably should be too). Since they are fairly easy to understand by themselves, I don't feel like this is a significant regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants