[Bug] Can't use react-plaid-link due to react-load-script issue

[mikecousins]

• I'd be willing to implement a fix

Describe the bug

The react-plaid-link library uses react-load-script and when react-load-script is in your project it seems to kill the build.

To Reproduce

await packageJsonAndInstall({
  dependencies: {
    [`react-plaid-link`]: `1.5.0`
  }
});

Screenshots

C:\GitHub\passiv-web [master ≡ +1 ~3 -0 !]> yarn build
Creating an optimized production build...
Failed to compile.

.yarn\$$virtual\react-load-script-virtual-d93fb15f1c\0\cache\react-load-script-npm-0.0.6-df7c033ca3-2.zip\node_modules\react-load-script\lib\index.js
Module not found: A package is trying to access a peer dependency that should be provided by its direct ancestor but isn't  

command not found: react-scripts
C:\GitHub\passiv-web [master ≡ +1 ~3 -0 !]> yarn why react-load-script
├─ react-plaid-link@npm:1.5.0
│  └─ react-load-script@npm:0.0.6 (via npm:0.0.6)
│
└─ react-plaid-link@npm:1.5.0 [ed127]
   └─ react-load-script@npm:0.0.6 [cfb96] (via npm:0.0.6 [cfb96])
C:\GitHub\passiv-web [master ≡ +1 ~3 -0 !]>

Environment if relevant (please complete the following information):

• OS: Windows 10 latest
• Node version: 13.6.0
• Yarn version: 2.0.0-rc28

Additional context

Add any other context about the problem here.

[yarnbot]

We couldn't reproduce your issue (all the assertions passed on master).

[merceyz]

react-plaid-link is missing a dependency/peerDependency on prop-types

https://github.com/plaid/react-plaid-link/blob/7a70759ad63f9641729622e844758f8a69f29ded/src/PlaidLink.js#L3
https://github.com/plaid/react-plaid-link/blob/7a70759ad63f9641729622e844758f8a69f29ded/package.json#L29-L35

[quinnturner]

Addressed here (waiting for merge): plaid/react-plaid-link#75

[yarnbot]

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolution faster). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label.

[merceyz]

Fixed upstream in plaid/react-plaid-link#81