Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build es5-compatible lib #2275

Closed
wants to merge 3 commits into from
Closed

Build es5-compatible lib #2275

wants to merge 3 commits into from

Conversation

methyl
Copy link

@methyl methyl commented Dec 16, 2016

Summary

In order to use yarn's parse.js in nodesecurity/nsp (nodesecurity/nsp#142) to be able to support yarn.lock and probably in other packages which are not node4 compatible, I want to be able to get es5-compatible version of this library.

Test plan

Build works as expected:

scripts/build-dist.sh
+ npm run build

> yarn@0.19.0-0 build /Users/lucek/workspace/yarn
> gulp build

[16:22:17] Using gulpfile ~/workspace/yarn/gulpfile.js
[16:22:17] Starting 'build-modern'...
[16:22:17] Starting 'build-legacy'...
[16:22:17] Starting 'build-es5'...
[16:22:31] Finished 'build-modern' after 14 s
[16:22:31] Finished 'build-legacy' after 14 s
[16:22:31] Finished 'build-es5' after 14 s
[16:22:31] Starting 'build'...
[16:22:31] Finished 'build' after 34 μs

@bestander
Copy link
Member

Thanks for the PR but for now we only support Node 4+.
You are welcome to make a fork and support older versions of Node for your needs.

@bestander bestander closed this Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants