Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpm should not rebuild native modules unnecessarily #248

Closed
skevy opened this issue Aug 25, 2016 · 1 comment
Closed

kpm should not rebuild native modules unnecessarily #248

skevy opened this issue Aug 25, 2016 · 1 comment
Labels

Comments

@skevy
Copy link
Contributor

skevy commented Aug 25, 2016

I was noticing that in subsequent kpm install runs in my project, it was rebuilding native modules even though nothing had changed. It turned out, after I put in some logging, that bcrypt and ursa were being marked as fresh every single run. As a debugging measure, I made the relevant code ignore .kpm-metadata.json: https://github.com/facebook/fbkpm/blob/master/src/util/fs.js#L214. This stopped the packages from being rebuilt. Obviously this isn't the long term solution, but I hope that helps you all diagnose and fix the real issue :)

@skevy skevy added the cat-bug label Aug 25, 2016
@sebmck
Copy link
Contributor

sebmck commented Sep 8, 2016

Fixed via a6d2936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants