save-prefix false in v0.28.4 adds false keyword to the package version

[lgraziani2712]

Do you want to request a feature or report a bug?

• Report a bug.

What is the current behavior?

When I run yarn add <package> or yarn add --dev <package it adds the false keywork as a prefix for the package version. E.g.:

{
  "eslint": "false4.4.0"
}

If the current behavior is a bug, please provide the steps to reproduce.

1. Add a .yarnrc file with save-prefix false as its content.
2. yarn add --dev eslint.

What is the expected behavior?

The false keyword it doesn't needs to be written to the package.json file.

Please mention your node.js, yarn and operating system version.

• Nodejs: v8.2.1.
• Windows 10.
• yarnpkg v0.28.4

Thank you!

[rally25rs]

Related: #2653 #1088

[BYK]

Why do we need save-prefix to support a keyword? What if someone actually wants to prefix things with false (I know, highly unlikely but why prevent it?)

[BYK]

Why do we need save-prefix to support a keyword?

Okay sorry. Just read #2653 and now I understand the motivation. That said I'd rather us supporting empty strings for settings. Would like to close this in favor of #2653 which I prioritized for 1.0. Works for you?

[OliverJAsh]

To confirm, what's the expected behaviour here? On 1.0.2 I'm seeing false in my versions.

[BYK]

@OliverJAsh

To confirm, what's the expected behaviour here? On 1.0.2 I'm seeing false in my versions.

If there's false in your config file, it is expected to see false. Use an empty string in your .yarnrc file or wait until we have #4471 merged and use the new and shiny save-exact setting ;)