Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect unmet peer dependency warning #4969

Closed
betalb opened this issue Nov 21, 2017 · 2 comments
Closed

Incorrect unmet peer dependency warning #4969

betalb opened this issue Nov 21, 2017 · 2 comments
Assignees
Labels

Comments

@betalb
Copy link

betalb commented Nov 21, 2017

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
Yarn may warn about unmet peer dependencies even if they are installed

If the current behavior is a bug, please provide the steps to reproduce.

  • Install a set of packages that are triggering issueyarn add babel-core babel-loader webpack babel-cli
  • Install some dummy package yarn add peter
  • Check that yarn prints warning about unmet peer dependency: warning " > babel-loader@7.1.2" has unmet peer dependency "babel-core@6 || 7 || ^7.0.0-alpha || ^7.0.0-beta || ^7.0.0-rc".

Attaching generated yarn.lock & package.json

Without babel-cli issue is not showing up

What is the expected behavior?
No warnings about unmet peer dependencies should be printed, because bable-core is installed, and has version 6.26.0

Please mention your node.js, yarn and operating system version.
node: v8.9.0
yarn: 1.3.2
os: macOS 10.13.1

@ghost ghost assigned Daniel15 Nov 21, 2017
@ghost ghost added the triaged label Nov 21, 2017
@betalb
Copy link
Author

betalb commented Nov 21, 2017

Example was inspired by issue #4589 (comment)

@rally25rs
Copy link
Contributor

Duplicate #4743

Yarn isn't noticing when the peer dep is a direct dep from package.json. A fix is being worked on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants