yarn/npm differences result in package errors

[Spongman]

yarn v1.6.0

$ git clone https://github.com/Spongman/p5.js.git
$ cd p5.js
$ git checkout 158bacc3d099dc284f1a813a79a200f1db934308
$ npm install
$ npm run grunt eslint:source
$ rm -fr ./node_modules
$ git reset --hard
$ yarn
$ yarn grunt eslint:source

notice that when the packages are fetched with npm, the grunt run passes. when the packages are fetched by yarn, the grunt run fails.

[sth]

I get:

$ git checkout 158bacc3d099dc284f1a813a79a200f1db934308
fatal: reference is not a tree: 158bacc3d099dc284f1a813a79a200f1db934308

[Daniel15]

Please provide the output from the commands.

[rally25rs]

~/Projects 🐒   git clone https://github.com/processing/p5.js.git
Cloning into 'p5.js'...
remote: Counting objects: 37063, done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 37063 (delta 13), reused 22 (delta 9), pack-reused 37029
Receiving objects: 100% (37063/37063), 64.20 MiB | 2.05 MiB/s, done.
Resolving deltas: 100% (23105/23105), done.

~/Projects 🐒   cd p5.js/

~/Projects/p5.js (master) 🐒   git checkout 158bacc3d099dc284f1a813a79a200f1db934308
fatal: reference is not a tree: 158bacc3d099dc284f1a813a79a200f1db934308

The first and last characters of that commit SHA also don't match anything:

~/Projects/p5.js (master) 🐒   git log | grep 158bacc

~/Projects/p5.js (master) 🐒   git log | grep 34308

When run on master it seems to pass linting.

~/Projects/p5.js (master) 🐒   yarn grunt eslint:source
yarn run v1.6.0
$ grunt eslint:source
Running "eslint:source" (eslint) task

Done, without errors.
✨  Done in 5.87s.

[Spongman]

ugh, sorry. i have updated the repo url in the original comment (above).

here's the output:

$ git clone https://github.com/Spongman/p5.js.git
Cloning into 'p5.js'...
remote: Counting objects: 38027, done.
remote: Compressing objects: 100% (138/138), done.
remote: Total 38027 (delta 163), reused 199 (delta 131), pack-reused 37756
Receiving objects: 100% (38027/38027), 64.53 MiB | 5.61 MiB/s, done.
Resolving deltas: 100% (23783/23783), done.
Checking connectivity... done.
$ cd p5.js/
$ git checkout 158bacc3d099dc284f1a813a79a200f1db934308
Note: checking out '158bacc3d099dc284f1a813a79a200f1db934308'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 158bacc... fix invalid loadJSON signature usage in test
$ npm install

> iltorb@1.3.10 install /home/user/tmp/p5.js/node_modules/iltorb
> detect-libc prebuild-install || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.4.1
prebuild-install info looking for local prebuild @ prebuilds/iltorb-v1.3.10-node-v57-linux-x64.tar.gz
prebuild-install info looking for cached prebuild @ /home/user/.npm/_prebuilds/https-github.com-MayhemYDG-iltorb-releases-download-v1.3.10-iltorb-v1.3.10-node-v57-linux-x64.tar.gz
prebuild-install info found cached prebuild 
prebuild-install info unpacking @ /home/user/.npm/_prebuilds/https-github.com-MayhemYDG-iltorb-releases-download-v1.3.10-iltorb-v1.3.10-node-v57-linux-x64.tar.gz
prebuild-install info unpack resolved to /home/user/tmp/p5.js/node_modules/iltorb/build/bindings/iltorb.node
prebuild-install info unpack required /home/user/tmp/p5.js/node_modules/iltorb/build/bindings/iltorb.node successfully
prebuild-install info install Successfully installed prebuilt binary!

> phantomjs-prebuilt@2.1.16 install /home/user/tmp/p5.js/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...
  [==================================------] 84%
Received 22866K total.
Extracting tar contents (via spawned process)
Removing /home/user/tmp/p5.js/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1524634965100/phantomjs-2.1.1-linux-x86_64 -> /home/user/tmp/p5.js/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /home/user/tmp/p5.js/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

> husky@0.14.3 install /home/user/tmp/p5.js/node_modules/husky
> node ./bin/install.js

husky
setting up Git hooks
done

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.3 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1469 packages in 30.055s
$ npm run grunt eslint:source

> p5@0.6.0 grunt /home/user/tmp/p5.js
> grunt "eslint:source"

Running "eslint:source" (eslint) task

Done, without errors.
$ rm -fr ./node_modules
$ git reset --hard
HEAD is now at 158bacc fix invalid loadJSON signature usage in test
$ yarn
yarn install v1.6.0
info No lockfile found.
[1/4] Resolving packages...
warning browserify > glob > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt > minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt > glob > minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt > glob > graceful-fs@1.2.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
warning grunt > coffee-script@1.3.3: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
warning grunt > findup-sync > glob > minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt-contrib-connect > connect@2.30.2: connect 2.x series is deprecated
warning grunt-contrib-jshint > jshint > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt-contrib-watch > gaze > globule > minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning grunt-contrib-yuidoc > yuidocjs > yui > request > node-uuid@1.4.8: Use uuid module instead
warning grunt-jscs > jscs > jsonlint > nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
warning grunt-jscs > jscs > jscs-preset-wikimedia@1.0.1: Deprecated in favour of eslint-config-wikimedia. -- https://phabricator.wikimedia.org/T118941
warning grunt-release-it > release-it > github@9.2.0: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
warning grunt-saucelabs > requestretry > request > node-uuid@1.4.8: Use uuid module instead
warning grunt-saucelabs > sauce-tunnel > request > node-uuid@1.4.8: Use uuid module instead
[2/4] Fetching packages...
info fsevents@1.2.2: The platform "linux" is incompatible with this module.
info "fsevents@1.2.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " > grunt-mocha-test@0.13.3" has unmet peer dependency "mocha@>=1.20.0".
[4/4] Building fresh packages...
success Saved lockfile.
Done in 23.60s.
$ yarn grunt eslint:source

yarn run v1.6.0
$ grunt eslint:source
Running "eslint:source" (eslint) task
/home/user/tmp/p5.js/src/core/error_helpers.js:488:27: Replace `·?·'null'` with `⏎··············?·'null'⏎·············` [Error/prettier/prettier]

1 problem
Warning: Task "eslint:source" failed. Use --force to continue.

Aborted due to warnings.
error Command failed with exit code 3.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.