Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.DS_Store files published + empty package directory #5720

Open
tkrotoff opened this issue Apr 24, 2018 · 1 comment
Open

.DS_Store files published + empty package directory #5720

tkrotoff opened this issue Apr 24, 2018 · 1 comment
Assignees
Labels

Comments

@tkrotoff
Copy link

tkrotoff commented Apr 24, 2018

The issue was first reported in Lerna GitHub: lerna/lerna#1394, Lerna dev said it's an issue with yarn publish

When using lerna publish, .DS_Store files in subdirectories (but not in root directory) are published and should not.
Example:

npm/yarn publish should ignore .DS_Store files by default so I don't know who is the culprit here.

Also got an empty package directory: https://unpkg.com/react-form-with-constraints@0.8.0-beta.1/ that I did not have before (and obviously I don't have this directory in my Git nor on my file system when running lerna publish).

Executable Version
lerna --version 2.10.1
npm --version 5.6.0
yarn --version 1.6.0
node --version v9.11.1

screen shot 2018-04-24 at 12 41 23

@ghost ghost assigned rally25rs Apr 24, 2018
@ghost ghost added the triaged label Apr 24, 2018
@rally25rs
Copy link
Contributor

From a quick glance, .DS_Store is in the list of ignored files and a non-workspace yarn pack seems to properly ignore it:

~/Projects/yarn-test 🐒   yarn init -y
yarn init v1.6.0
warning The yes flag has been set. This will automatically answer yes to all questions, which may have security implications.
success Saved package.json
✨  Done in 0.03s.

~/Projects/yarn-test 🐒   mkdir src

~/Projects/yarn-test 🐒   touch ./ok.js

~/Projects/yarn-test 🐒   touch src/ok.js

~/Projects/yarn-test 🐒   touch src/.DS_Store

~/Projects/yarn-test 🐒   yarn pack -f test.tgz
yarn pack v1.6.0
success Wrote tarball to "test.tgz".
✨  Done in 0.05s.

~/Projects/yarn-test 🐒   tar -tf test.tgz
package
package/ok.js
package/package.json
package/src
package/src/ok.js

I don't have time to rig up a workspace and lerna example right now, but I'll try to circle back around to this later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants