Yarn cache bug w/ Github URL packages

[luwes]

Bug

What is the current behavior?

yarn install fails to install subsequent Github URL packages with format
git+ssh://git@github.com:luwes/chameleon.git#cricket-v0.0.1-beta.3
git+ssh://git@github.com:luwes/chameleon.git#grasshopper-v0.0.1-beta.4

error Command failed.
Exit code: 128

What is the expected behavior?

yarn install installs the package

Node 10.6.0, Yarn 1.9.4, MacOS 10.13.3

[luwes]

Is it possible yarn caches GH packages only based on repository URL and version number?
If so I think it should also take in account the package name or at least the prefix of the full version after the hash e.g core-v1.1.2

[arcanis]

I need an actual repro, player/player isn't a valid repository.

[luwes]

Related issue: #3303
This comment feels spot on: #3303 (comment)

I think yarn is reusing the cache directory, but git doesn't like overwriting one branch with another in that directory.

[luwes]

I reproduced it with these public git tags:

yarn global add git+ssh://git@github.com:luwes/chameleon.git#cricket-v0.0.1-beta.1
yarn global add git+ssh://git@github.com:luwes/chameleon.git#cricket-v0.0.1-beta.2
yarn global add git+ssh://git@github.com:luwes/chameleon.git#grasshopper-v0.0.1-beta.3
yarn global add git+ssh://git@github.com:luwes/chameleon.git#cricket-v0.0.1-beta.3
yarn global add git+ssh://git@github.com:luwes/chameleon.git#grasshopper-v0.0.1-beta.4
yarn global add git+ssh://git@github.com:luwes/chameleon.git#cricket-v0.0.1-beta.4

[luwes]

Any more insights into this issue?

[luwes]

@arcanis I think the issue is that the cloned repo in that .tmp cache folder does not have the latest git tags.

It tries to create an git archive <tree-ish but exits with code 128. When I manually went in that folder and ran the git archive ... command it outputted fatal: not a tree object.

git tag in that folder did not list the newly added tag.

I traced it back to this line of code which does a git pull if there is a cached repo, but git pull does not add the new tags to the repo.
https://github.com/yarnpkg/yarn/blob/master/src/util/git.js#L322