Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace package with prerelease version and wildcard dep version #6719

Open
wclr opened this issue Nov 25, 2018 · 3 comments
Open

Workspace package with prerelease version and wildcard dep version #6719

wclr opened this issue Nov 25, 2018 · 3 comments
Assignees
Labels

Comments

@wclr
Copy link
Contributor

wclr commented Nov 25, 2018

Say there is a structure:

/root
 /packages/
  /a <- name: @mon/a, version: "1.0.0-rc1" //version contains prerelease id
  /b <- dependenciy: "@mon/a": "*"

yarn gives an error:

error Couldn't find package "@mono/a@*" required by "@mono/b@1.0.0" on the "npm" registry.

Probalby shoul just consider this available "prerelease" version if wilcard is used in dep?

@ghost ghost assigned arcanis Nov 25, 2018
@ghost ghost added the triaged label Nov 25, 2018
@mrjackdavis
Copy link

I just hit this issue. And have mixed thoughts.

On one hand, it would be great to have a wildcard which also applied to prereleases.
On the other it's probably not a good idea to deviate from existing syntax set by npm. I would especially loath changing the meaning of existing syntax.

Feels bad, but perhaps a new wildcard like % is the only viable choice if this was to be fixed.

Until such a solution is reached (if ever?), I'd recommend scripting the update of dependency versions tracked in your yarn workspace.

@arcanis
Copy link
Member

arcanis commented May 7, 2019

We actually already slightly deviate in one specific case: peer dependencies warnings (because we consider that the intent isn't ambiguous here). We could do that for workspaces as well.

@georeith
Copy link

To anyone else who came here because they use are using lerna and yarn and have * in their root package.json pointing at a module in the monorepo itself and want to do a prerelease of the monorepo.

Replace the * with a relative file:packages/name-of-your-package and you're golden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants