Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nohoist not working as expected in monorepo #6998

Closed
chrisdrackett opened this issue Feb 4, 2019 · 2 comments
Closed

nohoist not working as expected in monorepo #6998

chrisdrackett opened this issue Feb 4, 2019 · 2 comments
Assignees
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+. triaged

Comments

@chrisdrackett
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?

I have react-native-web in one of the packages in my repo that is a require of another package. I also have nohoist setup in the root of my monorepo. However I'm not seeing react-native-web being installed in the node_modules of the web project as I expected with nohoist.

test repo here: https://github.com/tiltshift/monoWorkspaces/tree/react-native-web

What is the expected behavior?

react-native-web is installed in the web node_modules based on the project nohoist settings.

Please mention your node.js, yarn and operating system version.

node: v11.3.0
yarn 1.12.3

@steida
Copy link

steida commented Feb 4, 2019

@chrisirhc Because of often broken Yarn workspace (it's not the first weird bug) feature, what do you think we should use instead? Plain npm / yarn package.json files with code shared via private npm modules? Do you have a better idea?

Heck, Yarn workspace does not support even caret resolutions! #6995

@ghost ghost assigned rally25rs Feb 5, 2019
@ghost ghost added the triaged label Feb 5, 2019
@paul-soporan
Copy link
Member

Closing as fixed in v2.

https://yarnpkg.com/getting-started/migration

@paul-soporan paul-soporan added the fixed-in-modern This issue has been fixed / implemented in Yarn 2+. label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+. triaged
Projects
None yet
Development

No branches or pull requests

4 participants