Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks using yarn link are unnecessarily two-level #7614

Open
richard-ejem opened this issue Oct 10, 2019 · 0 comments
Open

Symlinks using yarn link are unnecessarily two-level #7614

richard-ejem opened this issue Oct 10, 2019 · 0 comments

Comments

@richard-ejem
Copy link

richard-ejem commented Oct 10, 2019

Do you want to request a feature or report a bug?
bug - it BC breaks previously working scenarios

Steps to reproduce:

git clone git@github.com:inspect-js/node-deep-equal.git
cd node-deep-equal
yarn link
mkdir ../app
cd ../app
yarn link deep-equal
readlink node_modules/deep-equal

What is the current behavior?

readlink in the above script outputs ../../../../../.config/yarn/link/deep-equal (which is another symlink)

What is the expected behavior?
readlink in the above script outputs ../../node-deep-equal which is the actual path of deep-equal package

Why it is a bug / unexpected BC break
It worked as expected previously (i was using Yarn 1.9.4). I've found out it was broken by this revert: #6321 .
It broke the scenario where I was building the app inside a Docker container and developing it in IDE on the host machine. The yarn/link global directory is placed outside of the volume shared between Docker and host, therefore the symlinks are obviously broken when viewed from IDE on my host machine.

Please mention your node.js, yarn and operating system version.
Yarn 1.19.1
Node v12.2.0
MacOS 10.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant