Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing Release v1.69.1 #2198

Merged
merged 3 commits into from Jan 25, 2023
Merged

Preparing Release v1.69.1 #2198

merged 3 commits into from Jan 25, 2023

Conversation

AllenLuUber
Copy link
Collaborator

No description provided.

@AllenLuUber AllenLuUber requested review from gandhikrishna, jronak and felipefiali and removed request for gandhikrishna January 25, 2023 03:15
@AllenLuUber AllenLuUber changed the title - [ ] Description and context for reviewers: one partner, one stranger - [ ] Docs (package doc) - [ ] Entry in CHANGELOG.md Preparing Release v1.69.1 Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 85.31% // Head: 85.33% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f685228) compared to base (81c0abf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2198      +/-   ##
==========================================
+ Coverage   85.31%   85.33%   +0.01%     
==========================================
  Files         270      270              
  Lines       15463    15465       +2     
==========================================
+ Hits        13193    13197       +4     
+ Misses       1847     1845       -2     
  Partials      423      423              
Impacted Files Coverage Δ
internal/observability/call.go 94.06% <100.00%> (ø)
yarpcerrors/yarpcerrorclassifier.go 100.00% <100.00%> (ø)
transport/internal/tls/muxlistener/listener.go 95.91% <0.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [1.69.1] - 2023-1-24
### Changed
-- yarpcerrors: export logic to get server and client fault type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: drop extra -

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops somehow I did not see this comment. :(

@AllenLuUber AllenLuUber merged commit 8ccd79a into master Jan 25, 2023
@AllenLuUber AllenLuUber deleted the allenlu/release branch January 25, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants