Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External IP deduction doesn't work #78

Closed
dmitrmax opened this issue Jul 21, 2022 · 1 comment
Closed

External IP deduction doesn't work #78

dmitrmax opened this issue Jul 21, 2022 · 1 comment

Comments

@dmitrmax
Copy link

Hi! The source code tries to resolve external IP of server by using API of api.externalip.net which is no longer available. It is no problem to replace it with another service's URL. But why do it at all? Why can't we use DNS to find out NS record responsible for the given domain and then retrive A record for it? I cannot figure out the case where external IP doesn't match the IP in A-record for the nameserver. Do you?
@yarrick
Copy link
Owner

yarrick commented Jul 22, 2022

The code in git uses myip.opendns.com since 2032b44.

I have been thinking about something similar for the other bug when the server might be asked over IPv6 and needs to know its v4 address.

@yarrick yarrick closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yarrick @dmitrmax