Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageMediaStream.Default is always false #4

Closed
srenrd opened this issue Jan 5, 2019 · 3 comments
Closed

LanguageMediaStream.Default is always false #4

srenrd opened this issue Jan 5, 2019 · 3 comments

Comments

@srenrd
Copy link

srenrd commented Jan 5, 2019 •
edited
Loading

Hey, I have multiple mkv movies with ac3 audio tracks that has a Default flag. When inspecting them with the MediaInfo program, I can verify that each movie has an ac3 track with the flag set to "Yes". Yet when using your wrapper the default flag aka. LanguageMediaStream.Default always appears as false? From my tests this is a proplem for both video and audio streams.
@srenrd
Copy link
Author

srenrd commented Jan 7, 2019

The problem is that the flags are represented by "Yes" and "No". You are using bool.TryParse for the conversion which will always fail. Solution could be to add a custom bool TryParse method for the flags.

@yartat
Copy link
Owner

yartat commented Jan 7, 2019

Thank you for solution. I will fix this issue for a close time.

@yartat
Copy link
Owner

yartat commented Nov 18, 2019

Was closed in release 18.12

@yartat yartat closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yartat @srenrd