Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong port when testing server connection #189

Closed
mariorossi77 opened this issue Dec 2, 2022 · 2 comments · Fixed by #192
Closed

[BUG] Wrong port when testing server connection #189

mariorossi77 opened this issue Dec 2, 2022 · 2 comments · Fixed by #192
Assignees
@Yash-Garg
Labels
C-bug Something isn't working
Milestone
v1.0

Comments

@mariorossi77
Copy link

mariorossi77 commented Dec 2, 2022 •
edited

client connects to the server on the wrong port

when configuring the server, after specifying "HTTP" and port "443"
the client connects to port 80

the client should connect to port 443 even if the standard http port is 80
@mariorossi77 mariorossi77 added the C-bug Something isn't working label Dec 2, 2022
@mariorossi77 mariorossi77 changed the title wrong port when test wrong port when testing server connection Dec 2, 2022
@Yash-Garg Yash-Garg added this to the v1.0 milestone Dec 2, 2022
@Yash-Garg Yash-Garg mentioned this issue Dec 2, 2022
Merged
@Yash-Garg Yash-Garg linked a pull request Dec 2, 2022 that will close this issue
feat: allow usage of self-signed certificates #190
Merged
@Yash-Garg
Copy link
Owner

Yash-Garg commented Dec 2, 2022 •
edited

@kusky3 can you follow the Bug Report template please? I'll have a look at the issue.

@Yash-Garg Yash-Garg removed a link to a pull request Dec 3, 2022
feat: allow usage of self-signed certificates #190
Merged
@mariorossi77 mariorossi77 changed the title wrong port when testing server connection [BUG] wrong port when testing server connection Dec 3, 2022
@mariorossi77 mariorossi77 changed the title [BUG] wrong port when testing server connection [BUG] Wrong port when testing server connection Dec 3, 2022
@Yash-Garg Yash-Garg self-assigned this Dec 4, 2022
@Yash-Garg Yash-Garg mentioned this issue Dec 7, 2022
Merged
@Yash-Garg
Copy link
Owner

Yash-Garg commented Dec 7, 2022 •
edited

@kusky3 I've implemented a solution by making port optional, so if you are using any kind of proxy which handles the port forwarding, leaving the port as empty should work just fine now.

Will create a release after the PR has been merged.

Yash-Garg added a commit that referenced this issue Dec 7, 2022
@Yash-Garg
fix(config): make port an optional parameter to comply with proxies (#…
5bc7d0f 
…192)

Closes #189
@Yash-Garg Yash-Garg mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yash-Garg Yash-Garg

Labels
C-bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fix(config): make port an optional parameter to comply with proxies Yash-Garg/qBittorrent-Manager
2 participants
@Yash-Garg @mariorossi77