-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Navbar disappearance #14
Comments
This issue is assigned toy you @adarsh1001111 Acceptance criteria:
Testing Scope:
Ask doubts on this thread if you have any. |
'Footer' and 'Navbar' , both dissaperar at "/chat" route. If no PRs yet, then i would like to contribute to this.
|
Thanks for volunteering , since there were no clear instructions in the readme file about setting the project up using vite+react it took a little time but m working on this one ! Thank You |
![]() @Yash-Parsana ![]() |
It would be better if you delete the if-else block , And simply do return statement once. |
I already wrote in my PR that i kept the if else block for the ease to debug any issue created by my edit(cause i was not able to test it) please go through the PR @MishraTanishq619 |
@adarsh1001111 keeping header and footer in chat page same as other pages was causing ui related issues in main chat screen so as temporary fix i had removed them by if condition but it is not good practice so we should fix it now. you have to solve that ui bug in chat screen. |
The navbar disappears when the Chat section is clicked without login!
![Screenshot 2024-05-11 at 2 27 17 PM](https://private-user-images.githubusercontent.com/130575709/329768380-1b472475-42ba-48fa-9631-4c04d78d18ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4ODcwODQsIm5iZiI6MTcyMzg4Njc4NCwicGF0aCI6Ii8xMzA1NzU3MDkvMzI5NzY4MzgwLTFiNDcyNDc1LTQyYmEtNDhmYS05NjMxLTRjMDRkNzhkMThiYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxN1QwOTI2MjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMGY4Mzc1ODY2MmU1MGY1ZWM3N2QxMDhkMjg5NDNiMTYxMWRkNDA3MjczYmVhODMzNmQ4YTdjYWRjNzAxYTk4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._QIZH4LVINYDuPf0DGK0aGpJqj9k1IeEgTF40gJ1GoY)
This bug needs to be fixed.
Also i suggest beforehand that chat option must not be available before the login validation of the user.
The text was updated successfully, but these errors were encountered: