Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Navbar disappearance #14

Open
adarsh1001111 opened this issue May 11, 2024 · 7 comments
Open

[Bug] Navbar disappearance #14

adarsh1001111 opened this issue May 11, 2024 · 7 comments
Assignees
Labels
bug Something isn't working gssoc level3

Comments

@adarsh1001111
Copy link

The navbar disappears when the Chat section is clicked without login!
This bug needs to be fixed.
Also i suggest beforehand that chat option must not be available before the login validation of the user.
Screenshot 2024-05-11 at 2 27 17 PM

@Yash-Parsana
Copy link
Owner

This issue is assigned toy you @adarsh1001111

Acceptance criteria:

  • Nav bar should be visible to in chat section.
  • chat screen should be rendered without any UI issue after login.
  • Leaderboard and chat option should be visible to unauthenticated user as well

Testing Scope:

  • Create two testing accounts and test chat section by dummy chat. provide screen recording with PR.

Ask doubts on this thread if you have any.

@MishraTanishq619
Copy link

'Footer' and 'Navbar' , both dissaperar at "/chat" route.
Becouse this is how code is written.

If no PRs yet, then i would like to contribute to this.
Also, Please state specefically which would be needed at "/chat" route i.e

  • Navbar
  • Footer
  • or Both

@adarsh1001111
Copy link
Author

'Footer' and 'Navbar' , both dissaperar at "/chat" route. Becouse this is how code is written.

If no PRs yet, then i would like to contribute to this. Also, Please state specefically which would be needed at "/chat" route i.e

  • Navbar
  • Footer
  • or Both

Thanks for volunteering , since there were no clear instructions in the readme file about setting the project up using vite+react it took a little time but m working on this one ! Thank You

@adarsh1001111
Copy link
Author

adarsh1001111 commented May 12, 2024

Screenshot 2024-05-13 at 9 21 10 AM

@Yash-Parsana
I fixed the bug but ,
Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that.
Also can u specify how to test the app using chat elaborately with setup and files .

Screenshot 2024-05-12 at 11 52 58 PM

@MishraTanishq619
Copy link

Screenshot 2024-05-13 at 9 21 10 AM @Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files . Screenshot 2024-05-12 at 11 52 58 PM

It would be better if you delete the if-else block , And simply do return statement once.

@adarsh1001111
Copy link
Author

Screenshot 2024-05-13 at 9 21 10 AM @Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files . Screenshot 2024-05-12 at 11 52 58 PM

It would be better if you delete the if-else block , And simply do return statement once.

I already wrote in my PR that i kept the if else block for the ease to debug any issue created by my edit(cause i was not able to test it) please go through the PR @MishraTanishq619

@Yash-Parsana
Copy link
Owner

@adarsh1001111 keeping header and footer in chat page same as other pages was causing ui related issues in main chat screen so as temporary fix i had removed them by if condition but it is not good practice so we should fix it now. you have to solve that ui bug in chat screen.
i have provided firbase config file now you can use it to test chat screen. Create real chat scenario by using two dummy users.
and yes we want both header and footer in chat page.
And i am adding steps to run project in readme file.

cc: @MishraTanishq619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level3
Projects
None yet
Development

No branches or pull requests

3 participants