Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the UI #39

Open
Rashmisingh-18 opened this issue Oct 3, 2022 · 12 comments · May be fixed by #60
Open

Improving the UI #39

Rashmisingh-18 opened this issue Oct 3, 2022 · 12 comments · May be fixed by #60
Assignees
Labels

Comments

@Rashmisingh-18
Copy link

Want to add some changes in UI like improving navbar, adding hover and transition effects to cards, adding favicon and improving the footer.

@Rashmisingh-18
Copy link
Author

Hey @yashikabhargava, please assign this issue to me under hacktoberfest 2022.

@yashikabhargava
Copy link
Owner

@Rashmisingh-18 Can you please provide more information about the changes that you are planning on doing like

  • How are you going to improve the navbar and footer?
    And favicon is already being added by someone else so please do'nt add that as it will cause conflicts.

@yashikabhargava yashikabhargava added hacktoberfest enhancement New feature or request labels Oct 3, 2022
@shashank-iter
Copy link
Contributor

@yashikabhargava Hey Yashika, actually I saw your repo on twitter and was trying to improve UI, I added some gradients and Glassmorphism to the Cards. Would you like to have a look ?

@yashikabhargava
Copy link
Owner

@yashikabhargava Hey Yashika, actually I saw your repo on twitter and was trying to improve UI, I added some gradients and Glassmorphism to the Cards. Would you like to have a look ?

@shashank-iter Please raise an issue using the issue template provided and attach the screenshots, I'd be glad to take a look.

@shashank-iter
Copy link
Contributor

Sure just doing that.

@Rashmisingh-18
Copy link
Author

Hey @yashikabhargava, I raised this issue, would be glad if you assign this to me.

@yashikabhargava
Copy link
Owner

Yes. @Rashmisingh-18 I'll be assigning it to you only but please provide more information about the changes you are planning on doing like-

How are you going to improve the navbar and footer?
And favicon has already been added by someone else so please don't add that.

@Rashmisingh-18
Copy link
Author

Uploading Navbar.png…
In the navbar, want to add transition effects, borders, etc, improve that 'Get Started button.
Uploading Footer.png…
And in the footer, want to include some more info, like 'quick links', 'Services', and 'Social Media handles.
Also after 'contact us', there should be a section that shows 'why you should choose this website for better learning'.

@yashikabhargava
Copy link
Owner

Sounds good, assigning this issue to you.

@Rashmisingh-18
Copy link
Author

Made changes in Navbar as:
navbar_webX
And in the footer as:
footer_webX

Please reply if any other changes are required.

@yashikabhargava
Copy link
Owner

Looking great, There is just a minor typo in the spelling of 'and' in the footer, Please fix that and then go ahead and open a PR.

@Rashmisingh-18 Rashmisingh-18 linked a pull request Oct 4, 2022 that will close this issue
3 tasks
@centurion6x
Copy link
Contributor

centurion6x commented Oct 14, 2022

hey @Rashmisingh-18 is your nav-bar persistent?
Not trying to highjack, but when your PR is merged we'll have a whole new nav bar so no use in putting new issues and working on a nav bar that's gonna get replaced. 😅
Also it looks awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants