Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer should check if TextView is null #13

Closed
dirkam opened this issue Dec 24, 2020 · 1 comment · Fixed by #12
Closed

Timer should check if TextView is null #13

dirkam opened this issue Dec 24, 2020 · 1 comment · Fixed by #12

Comments

@dirkam
Copy link

dirkam commented Dec 24, 2020

Thanks for this library.

I believe Timer should check if textview is null before displaying the text. Similar to Stopwatch.

This way it's not possible to use Timer without the textview and it also makes it hard to use the Timer in different scenarios.

Thanks.

@yashovardhan99 yashovardhan99 linked a pull request Dec 24, 2020 that will close this issue
@yashovardhan99
Copy link
Owner

Hi, Thanks a lot for opening the issue. This issue was fixed in #12. However, I didn't get time to release a new version. You can try using the timer directly from the master branch to solve your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants