Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth for users to authenticate #5

Open
yashrsharma44 opened this issue Jun 3, 2020 · 2 comments
Open

Add OAuth for users to authenticate #5

yashrsharma44 opened this issue Jun 3, 2020 · 2 comments
Labels
enhancement New feature or request feature-request Feature request for the new version good first issue Good for newcomers
Milestone
v3

Comments

@yashrsharma44
Copy link
Owner

Acceptance Criteria -

  • Add OAuth for users
  • OAuth support for GitHub / Google
@yashrsharma44 yashrsharma44 added enhancement New feature or request good first issue Good for newcomers feature-request Feature request for the new version labels Jun 3, 2020
@yashrsharma44 yashrsharma44 added this to the v3 milestone Jun 3, 2020
@harshil15999
Copy link

@yashrsharma44 is it wise to use Oauth since it is a terminal based chatroom? shouldnt we use ssh

@yashrsharma44
Copy link
Owner Author

Yeah, that's true. Originally, I intended to use this application in a web browser though gRPC gateway - https://github.com/grpc-ecosystem/grpc-gateway

But I later added that we can add in a terminal support as well.

For this issue we shall use SSH for terminal app and oauth for web app as well.
Since webapp hasn't been made, we can concentrate on SSH to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature-request Feature request for the new version good first issue Good for newcomers
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@harshil15999 @yashrsharma44