Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs do not appear when Debug.Log() called on async callback and not on main thread. #17

Closed
andrewspalato opened this issue Dec 27, 2019 · 7 comments

Comments

@andrewspalato
Copy link

andrewspalato commented Dec 27, 2019

Hello, @yasirkula really love the UnityIngameDebugConsole and your awesome unity plugins, works great, but I have found that logs do not appear in the console if we are using asynchronous callbacks, is there a way to make these visible?

An example of this is using Firebase storage and their ContinueWith() Task callbacks.

The logs appear in adb logcat fine, but I would also like to see them inside the in game console too.

@andrewspalato andrewspalato changed the title Logs do not appear when Debug.Log() is not on main thread. Logs do not appear when Debug.Log() called on async callback and not on main thread. Dec 27, 2019
@yasirkula
Copy link
Owner

I'll try to reproduce the issue by calling Debug.Log in a separate thread, as soon as possible.

@yasirkula
Copy link
Owner

Can you unzip the attached archive and import the unitypackage inside it to your project? I've updated the plugin and would appreciate it if you could give it a shot before I release the update publicly.

IngameDebugConsole.zip

@andrewspalato
Copy link
Author

Thanks! This works but adding static commands will not work in a build from my test.

@yasirkula
Copy link
Owner

Do you mean the ConsoleMethod attribute? Did it work properly for the previous version? What are your build settings, e.g. IL2CPP, .NET 4.5, ProGuard minification and etc.?

@andrewspalato
Copy link
Author

IL2CPP
.NET 4.5
Proguard Minify (using user proguard)

LogAllCommands and LogSystemInfo does not exist in DebugLogConsole.

@yasirkula
Copy link
Owner

This release should fix it: IngameDebugConsole.zip

@andrewspalato
Copy link
Author

@yasirkula Thank you! Commands work, debug logs also work async. All works with Proguard enabled too.

yasirkula added a commit that referenced this issue Jan 2, 2020
- Added startMinimized option that can be enabled if enablePopup is disabled (it is basically a counterpart of startInPopupMode)
- Added DebugLogConsole.AddCommand for adding strongly typed functions as commands to the console
- Console commands now support Component parameter types
- Fixed #12 and #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants