Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration loader only prints parsed items #33

Closed
gavanderhoorn opened this issue Jun 1, 2023 · 0 comments · Fixed by #81
Closed

Configuration loader only prints parsed items #33

gavanderhoorn opened this issue Jun 1, 2023 · 0 comments · Fixed by #81
Labels
enhancement New feature or request good first issue Good for newcomers rv:0.1.0 Reported in MotoROS2 0.1.0 todo Not an issue, just a TODO
Milestone
untargeted

Comments

@gavanderhoorn
Copy link
Collaborator

The current implementation only prints the <key, value> pairs of config items it parses.

That's helpful, but anything which is not present in the configuration .yaml -- and so should get its default set -- will not be printed.

As we might change defaults over time, it would be important to have a complete dump of the g_nodeConfigSettings struct after parsing has finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers rv:0.1.0 Reported in MotoROS2 0.1.0 todo Not an issue, just a TODO
Projects
None yet
Milestone
untargeted
1 participant
@gavanderhoorn