Added configuration reader #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2319445257
💛 - Coveralls |
teclator
force-pushed
the
dinstaller_configuration
branch
2 times, most recently
from
baeeefd
to
b9d87fc
Compare
teclator
force-pushed
the
dinstaller_configuration
branch
from
b9d87fc
to
4c6f0be
Compare
dgdavid
approved these changes
May 12, 2022
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
imobachgs
reviewed
May 13, 2022
imobachgs
requested changes
May 13, 2022
imobachgs
approved these changes
May 13, 2022
teclator
force-pushed
the
dinstaller_configuration
branch
from
95ccada
to
45d6e92
Compare
imobachgs
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #132 we added support for an initial d-installer configuration through a YAML file. This PR aims to extended it allowing the user to customize some of the default settings using the kernel command line options.
Solution
We have moved the logic for reading the configuration from the Config class to a separate class and also a class for parsing the kernel command line options has been added. DInstaller kernel options needs to be declared using the dinst prefix by now and it also allow to specify an URL for fetching the configuration from, see the example above:
dinst.config_url=http://example.org/d-installer.yaml dinst.web.ssl=MODIFIEDThe reader can return a Config object merging all the configurations present in the system.
Testing