New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Simplify DBusError tests #182

Closed

imobachgs wants to merge 1 commit into master from simplify-dbus-error-test

Member

imobachgs commented Jun 8, 2022

Problem

DBusError tests:

rely on installer context
run on async

Running on installer context is not needed (not even desired) and async is only needed for the last test.

Solution

Allow rendering a component without the installer context.
Use async only where it is needed.


          Simplify DBusError tests

3386c6f

coveralls commented Jun 8, 2022 •

edited

Pull Request Test Coverage Report for Build 2462466942

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 86.733%

Totals
Change from base Build 2452854248:	0.01%
Covered Lines:	1816
Relevant Lines:	2080

💛 - Coveralls

Member Author

imobachgs commented Jun 8, 2022 •

edited

Replaced with #183.

imobachgs closed this

imobachgs deleted the simplify-dbus-error-test branch

July 28, 2022 09:53

imobachgs restored the simplify-dbus-error-test branch

November 23, 2022 09:04

imobachgs deleted the simplify-dbus-error-test branch

November 23, 2022 09:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment