Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TargetIpsPopup useEffect and related tests #197

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Fix TargetIpsPopup useEffect and related tests #197

merged 3 commits into from
Jun 14, 2022

Conversation

imobachgs
Copy link
Member

Fixes for #170.

@imobachgs imobachgs changed the base branch from master to display_machine_ip June 14, 2022 09:34
@mchf
Copy link
Member

mchf commented Jun 14, 2022

thanks

@mchf mchf merged commit 3e75f31 into display_machine_ip Jun 14, 2022
@mchf mchf deleted the fixes branch June 14, 2022 09:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2494234903

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 86.315%
Files with Coverage Reduction New Missed Lines %
service/lib/dinstaller/cmdline_args.rb 1 96.43%
service/lib/dinstaller/storage/proposal.rb 5 86.27%
service/lib/dinstaller/manager.rb 6 92.92%
service/lib/dinstaller/software.rb 26 66.07%
Totals Coverage Status
Change from base Build 2493272692: 0%
Covered Lines: 1994
Relevant Lines: 2286
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imobachgs @mchf @coveralls