Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split dbus api #31

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Split dbus api #31

merged 6 commits into from
Feb 22, 2022

Conversation

jreidinger
Copy link
Member

follow up of #29

Manually tested and now interface do what it should.

joseivanlopez
joseivanlopez approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can continue from here.

@jreidinger jreidinger merged commit b6b3577 into new-dbus-api Feb 22, 2022
@jreidinger jreidinger deleted the split-dbus-api branch February 22, 2022 16:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1882518652

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.212%
Totals Coverage Status
Change from base Build 1878381776: 0.0%
Covered Lines: 190
Relevant Lines: 226
💛 - Coveralls

@imobachgs imobachgs mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @joseivanlopez @ancorgs