New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] Start the daemon in the systemd service #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imobachgs
force-pushed
the
start-dbus
branch
from
February 14, 2023 14:47
c401b46
to
74e5714
Compare
imobachgs
force-pushed
the
start-dbus
branch
from
February 15, 2023 07:05
5e35698
to
6cfff78
Compare
imobachgs
force-pushed
the
start-dbus
branch
from
February 15, 2023 10:18
026ff29
to
c4d79d8
Compare
imobachgs
force-pushed
the
start-dbus
branch
from
February 15, 2023 12:16
36d47b6
to
411af8a
Compare
joseivanlopez
approved these changes
Feb 15, 2023
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 16, 2023
https://build.opensuse.org/request/show/1066106 by user IGonzalezSosa + dimstar_suse - Version 0.7 - Do not use a proxy to get the errors lists (gh#openSUSE/agama#424). - Add live reloading feature for easing the front-end development process (gh#openSUSE/agama#419). - Fix storage section crashing when proposal is not ready (gh#openSUSE/agama#418). - Better handling of software repositories (gh#openSUSE/agama#414): * Report issues when reading the software repositories. * Inform the user about the software proposal progress. * Add a button to reload the repositories (gh#openSUSE/agama#388). - Added a button for displaying the YaST logs (related to gh#openSUSE/agama#379) - UI fixes (gh#openSUSE/agama#401): * Add a fallback height for the layout * Fix some miss-alignments * Add missing icon * Ensure tooling serving and loading fo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
On the one hand, we are spawning a process with the
dbus-daemon
. The rest of the services are activated properly.After implementing the previous fix, I detected that the UI cannot get the validation errors for the storage layer. It cannot create the proxy and the component is not updated anymore. To fix this problem, I changed the implementation of the
getValidationErrors()
method to handle potential errors and not rely on proxies (better performance).Testing