Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Start the daemon in the systemd service #424

Merged
merged 8 commits into from Feb 15, 2023
Merged

Conversation

imobachgs
Copy link
Member

@imobachgs imobachgs commented Feb 14, 2023

Problem

  • D-Installer components crash in the installation media because the services are not started properly.

Solution

On the one hand, we are spawning a process with the dbus-daemon. The rest of the services are activated properly.

After implementing the previous fix, I detected that the UI cannot get the validation errors for the storage layer. It cannot create the proxy and the component is not updated anymore. To fix this problem, I changed the implementation of the getValidationErrors() method to handle potential errors and not rely on proxies (better performance).

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Feb 14, 2023

Coverage Status

Coverage: 77.654% (-0.1%) from 77.784% when pulling 411af8a on start-dbus into 2f3154a on master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit df2f403 into master Feb 15, 2023
@imobachgs imobachgs deleted the start-dbus branch February 15, 2023 16:02
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 16, 2023
https://build.opensuse.org/request/show/1066106
by user IGonzalezSosa + dimstar_suse
- Version 0.7
- Do not use a proxy to get the errors lists
  (gh#openSUSE/agama#424).

- Add live reloading feature for easing the front-end development
  process (gh#openSUSE/agama#419).

- Fix storage section crashing when proposal is not ready
  (gh#openSUSE/agama#418).

- Better handling of software repositories
  (gh#openSUSE/agama#414):
  * Report issues when reading the software repositories.
  * Inform the user about the software proposal progress.
  * Add a button to reload the repositories
    (gh#openSUSE/agama#388).

- Added a button for displaying the YaST logs
  (related to gh#openSUSE/agama#379)

- UI fixes (gh#openSUSE/agama#401):
  * Add a fallback height for the layout
  * Fix some miss-alignments
  * Add missing icon
  * Ensure tooling serving and loading fo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants