Default soapAction to a minimum version in WSClient

[ravirangappa]

This is more of a question and not a bug.

Starting vSphere 7.0, any SOAP request with empty soapAction header value is treated as a non-compliance with HTTP 1.1 specs and is rejected.

POST /sdk HTTP/1.1
SOAPAction
Content-Type: text/xml; charset=utf-8
User-Agent: Java/1.8.0_221
...

An empty header value violates the HTTP protocol mandating that the HTTP header
field format is a field-name followed by a colon and a value.
See https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

The soapAction value is currently being defaulted to an empty string in WsClient.java (line 157).
Can we default it instead to point to some minimum version, say SOAP_ACTION_V55?

Thanks,
Ravi

[michaelrice]

Sure send a patch and I’ll apply it and cut a release with the fix.

…

Sent from my iPhone

On Oct 15, 2019, at 01:52, ravirangappa ***@***.***> wrote:  This is more of a question and not a bug. Starting vSphere 7.0, any SOAP request with empty soapAction header value is treated as a non-compliance with HTTP 1.1 specs and is rejected. POST /sdk HTTP/1.1 SOAPAction Content-Type: text/xml; charset=utf-8 User-Agent: Java/1.8.0_221 ... An empty header value violates the HTTP protocol mandating that the HTTP header field format is a field-name followed by a colon and a value. See https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 The soapAction value is currently being defaulted to an empty string in WsClient.java (line 157). Can we default it instead to point to some minimum version, say SOAP_ACTION_V55? Thanks, Ravi — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ravirangappa]

Attached the patch file generated from level:
https://github.com/yavijava/yavijava.git/

Thanks,
Ravi

WSClient.java.zip

[ravirangappa]

Hello Michael,

Any ideas when this patch could get into a release?
We plan to migrate to yavijava from the legacy vijava library as soon as the proposed fix is available in a release. Until a formal release is available, we are stuck with vijava.

Thanks,
Ravi